berkay/bagdrill
1
0
Fork 0
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity Actions

Grey out NEXT COMBO on a drill round's last combo #23

Merged
berkay merged 1 commit from drill-next-disabled into main 2026-11-10 21:50:11 +03:00
Conversation 0 Commits 1 Files changed 5 +81 -11
berkay commented 2026-11-10 21:42:56 +03:00
Owner
Copy link

Requested by Berkay · project thread

Found in usability testing: in a Drill round with a single combo, NEXT COMBO did nothing. That was by design (NEXT jumps to the round's next combo and has nothing to jump to on the last one, PR #14), but the button looked active, so it read as a bug.

Changes

  • EngineState.hasNextDrillCombo: false on the round's last or only combo.
  • Round screen: in Drill mode NEXT COMBO is disabled (light grey outline, grey icon and label) when there is no next combo. PREV stays on, since it restarts the current combo. Random mode is unchanged (NEXT always calls a new combo).
  • BwSquareIconButton now has a disabled look when onPressed is null.

Tests

  • Engine: flag is true on the first of two combos, false on the last, false in a one-combo round.
  • Round screen: NEXT turns disabled after jumping to the last combo; with a single combo NEXT is disabled and PREV enabled.
  • flutter analyze clean, flutter test 117 passed.

No APK built, no version bump.

🤖 Generated with Claude Code

https://claude.ai/code/session_015s4aKoJZdE2DV1jJq1MHvp

<!-- claude-projects-attribution --> _Requested by **Berkay** · [project thread](https://claude.ai/code/project/chan_01T5Cs4GeJAnhjXKSJKvCDa2?thread=cmsg_01T5Cs4GeJAnhjXKSJKvCDa2PMit7Fx4afYW6uXczMAydf)_ Found in usability testing: in a Drill round with a single combo, NEXT COMBO did nothing. That was by design (NEXT jumps to the round's next combo and has nothing to jump to on the last one, PR #14), but the button looked active, so it read as a bug. ## Changes - `EngineState.hasNextDrillCombo`: false on the round's last or only combo. - Round screen: in Drill mode NEXT COMBO is disabled (light grey outline, grey icon and label) when there is no next combo. PREV stays on, since it restarts the current combo. Random mode is unchanged (NEXT always calls a new combo). - `BwSquareIconButton` now has a disabled look when `onPressed` is null. ## Tests - Engine: flag is true on the first of two combos, false on the last, false in a one-combo round. - Round screen: NEXT turns disabled after jumping to the last combo; with a single combo NEXT is disabled and PREV enabled. - `flutter analyze` clean, `flutter test` 117 passed. No APK built, no version bump. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_015s4aKoJZdE2DV1jJq1MHvp
In Drill mode NEXT jumps to the round's next combo and does nothing on the
last one, so with a single combo the button looked broken. It is now shown
disabled there; PREV stays on because it restarts the current combo.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015s4aKoJZdE2DV1jJq1MHvp
berkay merged commit 140900aa49 into main 2026-11-10 21:50:11 +03:00
berkay deleted branch drill-next-disabled 2026-11-10 21:50:11 +03:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
berkay/bagdrill!23
No description provided.